Filling as a good first bug to learn workflows. do not use 'else' after 'return': https://searchfox.org/mozilla-central/rev/14cb5e441592eca78b22ac0bdb5dfd1808ef4324/chrome/nsChromeRegistryContent.cpp#119 https://searchfox.org/mozilla-central/rev/14cb5e441592eca78b22ac0bdb5dfd1808ef4324/chrome/nsChromeRegistryChrome.cpp#332 pretty much the same code in two files They can be a bit simplified Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html Tutorial to contribute: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
Bug 1805100 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Filling as a good first bug to learn workflows. do not use 'else' after 'return': https://searchfox.org/mozilla-central/rev/14cb5e441592eca78b22ac0bdb5dfd1808ef4324/chrome/nsChromeRegistryContent.cpp#113-124 https://searchfox.org/mozilla-central/rev/14cb5e441592eca78b22ac0bdb5dfd1808ef4324/chrome/nsChromeRegistryChrome.cpp#328-337 pretty much the same code in two files They can be a bit simplified Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html Tutorial to contribute: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
Filling as a good first bug to learn workflows. do not use 'else' after 'return': https://searchfox.org/mozilla-central/rev/14cb5e441592eca78b22ac0bdb5dfd1808ef4324/chrome/nsChromeRegistryContent.cpp#113-124 https://searchfox.org/mozilla-central/rev/14cb5e441592eca78b22ac0bdb5dfd1808ef4324/chrome/nsChromeRegistryChrome.cpp#328-337 pretty much the same code in two files They can be a bit simplified https://clang.llvm.org/extra/clang-tidy/checks/readability/else-after-return.html Tutorial to contribute: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
Filling as a good first bug to learn workflows. do not use 'else' after 'return': https://searchfox.org/mozilla-central/rev/14cb5e441592eca78b22ac0bdb5dfd1808ef4324/chrome/nsChromeRegistryContent.cpp#113-124 https://searchfox.org/mozilla-central/rev/14cb5e441592eca78b22ac0bdb5dfd1808ef4324/chrome/nsChromeRegistryChrome.cpp#328-337 pretty much the same code in two files They can be a bit simplified Found by https://clang.llvm.org/extra/clang-tidy/checks/readability/else-after-return.html Tutorial to contribute: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html